Fix python_version operators in PyPI dependency marker parsing - #5318
Open
Pradeepbeleri wants to merge 1 commit into
Open
Pradeepbeleri wants to merge 1 commit into
Pradeepbeleri wants to merge 1 commit into
Conversation
Signed-off-by: Pradeepbeleri <[email protected]>
Pradeepbeleri
force-pushed
the
fix/pypi-python-version-operators
branch
from
September 14, 2026 05:48
782faa4 to
3de1348
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5309
Tasks
Run tests locally to check for errors.
Description
Fixes issue #5309 in
get_python_version_os()insidesrc/packagedcode/pypi.pywherepython_version_operatorscontained a duplicate'<'entry and was missing comparison operators'>','!=', and'~='.Because those operators were missing, dependency markers like
python_version > "3.8"orpython_version != "3.6"were silently dropping theirpython_versionextra data during PyPI package scanning.Changes Made
python_version_operatorsinsrc/packagedcode/pypi.pyto['<', '>', '>=', '==', '<=', '!=', '~='].AUTHORS.rst.CHANGELOG.rst.Verification
python -m pytest tests/packagedcode/test_pypi.py): 184 passed.